[Lldb-commits] [PATCH] D55230: [lit] Multiple build outputs and default target bitness

[Zachary Turner via lldb-commits]

If you have -o and multiple input files, which output file are you
specifying? It seems easier to just say that if multiple input files are
present, the output file names are automatically calculated
On Mon, Dec 3, 2018 at 2:48 PM Stella Stamenova via Phabricator <
reviews at reviews.llvm.org> wrote:

> stella.stamenova added inline comments.
>
>
> ================
> Comment at: lldb/lit/helper/build.py:664
> +    if args.output and args.mode == 'compile' and len(args.inputs) > 1:
> +        raise ValueError('Cannot specify -o with mode=compile and
> multiple source files.  Use --outdir instead.')
> +
> ----------------
> Why not? It makes sense that the test might still need to know and/or
> specify the name of the binary that was produced. The script could require
> that both -o and --outdir are specified, but I think -o is still needed.
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D55230/new/
>
> https://reviews.llvm.org/D55230
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181203/7eac2898/attachment.html>