[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

Mon Dec 3 01:23:29 PST 2018

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

In D55038#1314968 <https://reviews.llvm.org/D55038#1314968>, @JDevlieghere wrote:

> In D55038#1314336 <https://reviews.llvm.org/D55038#1314336>, @labath wrote:
>
> > I think the canonical way to do that would be to define a new feature in lit, which gets set when the target supports remote debugging and then use that feature in the REQUIRES directive.
>
>
> I've changed the check to non-windows (as it wouldn't compile there anyway). Is there anything not covered by this that would warrant this new feature?

Well.. FreeBSD also uses a local debugging plugin, though I don't believe anyone runs tests there on a regular basis. I suppose that could be handled by adding `system-freebsd` into the `UNSUPPORTED` clause...

Looks good to me, modulo one comment.

================
Comment at: source/Initialization/SystemLifetimeManager.cpp:27

-void SystemLifetimeManager::Initialize(
+llvm::Error SystemLifetimeManager::Initialize(
     std::unique_ptr<SystemInitializer> initializer,
----------------
The calls to this function in lldb-server and lldb-test need to be updated to handle the newly returned Error object.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55038/new/

https://reviews.llvm.org/D55038