[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 3 01:01:43 PST 2018
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Thanks for adding the test. looks good to me.
Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h:289-291
+ mutable std::unique_ptr<lldb_private::FileSpecList> m_filespec_ap;
+ typedef llvm::object::OwningBinary<llvm::object::Binary> OWNBINType;
+ mutable std::unique_ptr<OWNBINType> m_owningbin_up;
Consider using `Optional<T>` instead of `unique_ptr` to reduce pointer chasing.
Also, do these have to be `mutable`? I was expecting that you needed to lazy-initialize them from some `const` member, but I couldn't find any evidence of that...
CHANGES SINCE LAST ACTION
More information about the lldb-commits