[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 30 10:44:58 PST 2018


JDevlieghere added a comment.

In D55038#1314336 <https://reviews.llvm.org/D55038#1314336>, @labath wrote:

> In D55038#1314026 <https://reviews.llvm.org/D55038#1314026>, @JDevlieghere wrote:
>
> > Test didn't run. Is there a way to REQUIRE either darwin or linux?
>
>
> I think the canonical way to do that would be to define a new feature in lit, which gets set when the target supports remote debugging and then use that feature in the REQUIRES directive.


I've changed the check to non-windows (as it wouldn't compile there anyway). Is there anything not covered by this that would warrant this new feature?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55038/new/

https://reviews.llvm.org/D55038





More information about the lldb-commits mailing list