[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

[Aleksandr Urakov via lldb-commits]

Ah, it looks like my fail. I had an old piece of code, which retrieves an
FPO program for the old PDB plugin, and have shared it with Leonid (we are
colleagues). Sure, we will move this to the new plugin (and it looks like
it's not so difficult).

Am Fr., 30. Nov. 2018, 18:39 hat Zachary Turner <zturner at google.com>
geschrieben:

> It would be great if future work could go towards the native pdb plugin.
> To be honest, I’m trying very hard to get it to the point that the DIA
> plugin can be deleted, so large pieces of new functionality that only go to
> the DIA plugin are, in a way, wasted effort. I’m currently working on
> getting all of the tests in SymbolFile/PDB to pass with the other plugin,
> and there are only 2 remaining issues, neither of which is related to the
> plugin but rather clang.
>
> So I think it’s very close.
>
> Would it be possible to start making this transition now and reimplement
> this patch on the other plugin?
> On Fri, Nov 30, 2018 at 6:44 AM Leonid Mashinskiy via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> leonid.mashinskiy created this revision.
>> leonid.mashinskiy added reviewers: zturner, asmith, stella.stamenova,
>> aleksandr.urakov.
>> leonid.mashinskiy added a project: LLDB.
>> Herald added subscribers: lldb-commits, JDevlieghere, aprantl, mgorny.
>>
>> This patch makes LLDB able to retrieve proper values for function
>> arguments and local variables stored in PDB relative to VFRAME register.
>>
>> Patch contains retrieval of corresponding FPO table entries from PDB and
>> a generic translator from FPO programs to DWARF expressions to get correct
>> VFRAME value.
>>
>> Patch also improves variables-locations.test and makes this test passable
>> on x86.
>>
>> Related to D53086 <https://reviews.llvm.org/D53086>
>>
>>
>> Repository:
>>   rLLDB LLDB
>>
>> https://reviews.llvm.org/D55122
>>
>> Files:
>>   lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp
>>   lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script
>>   lit/SymbolFile/PDB/variables-locations.test
>>   source/Plugins/SymbolFile/PDB/CMakeLists.txt
>>   source/Plugins/SymbolFile/PDB/CodeViewRegisterMapping.cpp
>>   source/Plugins/SymbolFile/PDB/CodeViewRegisterMapping.h
>>   source/Plugins/SymbolFile/PDB/PDBFPOProgramToDWARFExpression.cpp
>>   source/Plugins/SymbolFile/PDB/PDBFPOProgramToDWARFExpression.h
>>   source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.cpp
>>   source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h
>>   source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181130/ee89cde0/attachment-0001.html>