[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

[Leonid Mashinskiy via Phabricator via lldb-commits]

leonid.mashinskiy created this revision.
leonid.mashinskiy added reviewers: zturner, asmith, stella.stamenova, aleksandr.urakov.
leonid.mashinskiy added a project: LLDB.
Herald added subscribers: lldb-commits, JDevlieghere, aprantl, mgorny.

This patch makes LLDB able to retrieve proper values for function arguments and local variables stored in PDB relative to VFRAME register.

Patch contains retrieval of corresponding FPO table entries from PDB and a generic translator from FPO programs to DWARF expressions to get correct VFRAME value.

Patch also improves variables-locations.test and makes this test passable on x86.

Related to D53086 <https://reviews.llvm.org/D53086>


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D55122

Files:
  lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.cpp
  lit/SymbolFile/PDB/Inputs/VariablesLocationsTest.script
  lit/SymbolFile/PDB/variables-locations.test
  source/Plugins/SymbolFile/PDB/CMakeLists.txt
  source/Plugins/SymbolFile/PDB/CodeViewRegisterMapping.cpp
  source/Plugins/SymbolFile/PDB/CodeViewRegisterMapping.h
  source/Plugins/SymbolFile/PDB/PDBFPOProgramToDWARFExpression.cpp
  source/Plugins/SymbolFile/PDB/PDBFPOProgramToDWARFExpression.h
  source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.cpp
  source/Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55122.176109.patch
Type: text/x-patch
Size: 61786 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181130/be151f1b/attachment-0001.bin>