[Lldb-commits] [PATCH] D55038: [Reproducers] Change how reproducers are initialized.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: source/Utility/Reproducer.cpp:41-42
+Reproducer::Reproducer(ReproducerMode mode, llvm::Optional<FileSpec> root) {
+  // It's unfortunate that we have to do so much I/O here that can fail. The
+  // best we can do is not initialize the reproducer.
+  switch (mode) {
----------------
labath wrote:
> It should be possible to bubble this all the way up to the `SBDebugger::Initialize` call. Is there a reason to not do that?
Do you mean having the private Initialize function return an error (and an SBError for the SB variant)?


================
Comment at: tools/driver/CMakeLists.txt:21
     liblldb
+    lldbUtility
     ${host_lib}
----------------
labath wrote:
> This is wrong. The driver should only  use the public API exposed via liblldb. Why did you need to do that?
I don't remember, anyway it's definitely not necessary or correct. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55038/new/

https://reviews.llvm.org/D55038