[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

Wed Nov 28 15:26:14 PST 2018

sgraenitz marked an inline comment as done.
sgraenitz added a comment.

Thanks for having a look.

================
Comment at: tools/debugserver/CMakeLists.txt:18
+
+  option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON)
+  set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING
----------------
JDevlieghere wrote:
> Why do we need to define this option again for the debugserver? Why can't it use the one from LLDBConfig.cmake?
In a debugserver standalone build we don't `include(LLDBConfig)`. It makes sense to me, because there is not much to configure when only building the debugserver.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55013/new/

https://reviews.llvm.org/D55013