[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

In D54914#1309901 <https://reviews.llvm.org/D54914#1309901>, @aprantl wrote:

> I would like to ask a general question that I (indirectly) also asked in D54731 <https://reviews.llvm.org/D54731>: Why do we want to implement support for building inferiors in LIT-based tests? IMHO, if we need to support for dealing with specific compilers, we should implement that once in `Makefile.rules` (which is in a declarative domain-specific-language for describing build logic) and write a `dotest.py`-style test instead. I'm assuming here that we need the support in `Makefile.rules` anyway to support the bulk of the tests. Having this support in two places increases the maintenance effort and cognitive load.


While I agree that having two ways to do something is bad, I have to say that the current Makefile.rules system is far from perfect. First of, it is geared towards creating a fully working executables (the kind that dotest tests expect), and if you want to do something more exotic, things get a lot harder. Also writing more complex logic in makefiles is hard, particularly when you need to be portable across various shells and make implementations.  In fact, the biggest feature of make, automatic dependency tracking, is unused now that we build tests out of tree and clean by nuking the build dir.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54914/new/

https://reviews.llvm.org/D54914