[Lldb-commits] [PATCH] D43886: [lldb] Add GetCurrentException APIs to SBThread, add frame recognizer for objc_exception_throw for Obj-C runtimes

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

The exception breakpoints know that libobjc.B.dylib`objc_exception_throw is where you stop for exception breakpoints, and now the ObjCExceptionRecognizer knows the same thing.  It always makes me nervous when two different places have the same hard-coded string.  Can we add an API to ObjCLanguageRuntime to get the FileSpec for the module and a function name for the exception function, and then have both CreateExceptionResolver and RegisterObjCExceptionRecognizer use that?  Actually it would be better to just add this to the LanguageRuntime, because then we could use it for the C++ CreateExceptionResolver and later (when one of us gets to it) for RegisterCPlusPlusExceptionRecognizer as well.  But since C++ can throw in a couple of places, it will need to return a vector of name+library pairs.

Other than this niggle, this looks great.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D43886/new/

https://reviews.llvm.org/D43886