[Lldb-commits] [PATCH] D54942: [PDB] Make PDB lit tests use the new builder

[Aleksandr Urakov via Phabricator via lldb-commits]

aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, stella.stamenova.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, abidh.

This patch makes old PDB plugin tests to use the new builder (see D54914 <https://reviews.llvm.org/D54914>).

There are some problems left:

- Clang called from the builder shows errors on types like `char16_t` and `char32_t`. That's why `enums-layout.test` and `typedefs.test` are made to use MSVC instead;
- The builder now doesn't support `/Gy` and `/order` options, so the old scheme is used in `function-level-linking.test`;
- The builder now doesn't support compilation of multiple sources and linking them together, so the old scheme is used for linking in `func-symbols.test`;
- On Windows 32-bit LLDB can debug only 32-bit applications, and 64-bit LLDB can debug only 64-bit applications. That's why the old scheme is left in dynamic tests `udt-layout.test`, `variables-locations.test` and `vbases.test`. If we will always compile the tests as 32-bit (64-bit), then they will fail on the 64-bit (32-bit) platform. That's why we just assume that the user runs the tests from the same command prompt where the build was run.

This one depends on D54914 <https://reviews.llvm.org/D54914>.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54942

Files:
  lit/SymbolFile/PDB/ast-restore.test
  lit/SymbolFile/PDB/calling-conventions.test
  lit/SymbolFile/PDB/class-layout.test
  lit/SymbolFile/PDB/compilands.test
  lit/SymbolFile/PDB/enums-layout.test
  lit/SymbolFile/PDB/func-symbols.test
  lit/SymbolFile/PDB/function-nested-block.test
  lit/SymbolFile/PDB/pointers.test
  lit/SymbolFile/PDB/type-quals.test
  lit/SymbolFile/PDB/typedefs.test
  lit/SymbolFile/PDB/variables.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54942.175435.patch
Type: text/x-patch
Size: 11270 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181127/025ffbb8/attachment-0001.bin>