[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere updated this revision to Diff 175377.
JDevlieghere added a comment.

Will land this tomorrow once we've figured out how to integrate tablegen with the Xcode project.

In the meantime I found some issues due to ordering of command options. Their relative order matters and we had tests relying on this. For example consider what happens when you say

  lldb -o 'do one thing' -s 'source/some/file'

You'd expect that the one-line is executed before sourcing the file. This wasn't the case with the previous version of this patch and is now fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54692/new/

https://reviews.llvm.org/D54692

Files:
  tools/driver/CMakeLists.txt
  tools/driver/Driver.cpp
  tools/driver/Driver.h
  tools/driver/Options.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54692.175377.patch
Type: text/x-patch
Size: 51665 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181127/60fa6f3e/attachment-0001.bin>