[Lldb-commits] [lldb] r347305 - [CMake] Streamline code signing for debugserver and pass entitlements to extended llvm_codesign

[Davide Italiano via lldb-commits]

On Tue, Nov 20, 2018 at 6:13 AM Stefan Granitz via lldb-commits
<lldb-commits at lists.llvm.org> wrote:
>
> Author: stefan.graenitz
> Date: Tue Nov 20 06:10:33 2018
> New Revision: 347305
>
> URL: http://llvm.org/viewvc/llvm-project?rev=347305&view=rev
> Log:
> [CMake] Streamline code signing for debugserver and pass entitlements to extended llvm_codesign
>

This broke the lldb-server tests, at least on MacOS.

Example:

ERROR: test_written_M_content_reads_back_correctly_debugserver
(TestLldbGdbServer.LldbGdbServerTestCase)

----------------------------------------------------------------------

Traceback (most recent call last):
  File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/decorators.py",
line 143, in wrapper
    func(*args, **kwargs)
  File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py",
line 1389, in test_written_M_content_reads_back_correctly_debugserver
    self.written_M_content_reads_back_correctly()
  File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestLldbGdbServer.py",
line 1333, in written_M_content_reads_back_correctly
    "print-message:"])
  File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py",
line 568, in prep_debug_monitor_and_inferior
    server = self.connect_to_debug_monitor(attach_pid=attach_pid)
  File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py",
line 403, in connect_to_debug_monitor
    server = self.launch_debug_monitor(attach_pid=attach_pid)
  File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py",
line 389, in launch_debug_monitor
    install_remote=False)
  File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/lldbtest.py",
line 890, in spawnSubprocess
    proc.launch(executable, args)
  File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/lldbtest.py",
line 323, in launch
    stdin=PIPE)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 710, in __init__
    errread, errwrite)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 1335, in _execute_child
    raise child_exception
OSError: [Errno 2] No such file or directory
Config=x86_64-/Users/davide/work/llvm-project-20170507/build-rel/bin/clang-8
----------------------------------------------------------------------

Ran 65 tests in 29.425s


I'm going to revert this for now. In order to reproduce, just run
`ninja check-lldb`.
I believe you didn't hit this because there were other three issues
piling up, but don't hesitate to ping me in case you can't repro this
locally.