[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I didn't read the patch in detail yet, these are just meta-comments:

It looks like the libOption approach (or this implementation of it) is missing the notion of option groups.  That's what you see in the first section of the lldb --help printout in the current version.  That's not that big a deal for the lldb driver command, as it doesn't have all that many disparate groups of options.  But Davide mentioned using this for the lldb command line as well, where we do use this to help auto-validate complex commands in a fair number of commands.

One thing that is missing from the SB API's was some way of defining the arguments and options for a command.  Because of this, Python based commands can't take part in the completions features and auto-help generation that "real" commands had.  If we had such a thing, then the driver could use the same mechanism to define itself as a command, and then just run itself at startup.  That would centralize all the argument parsing that we do regardless of how it is backed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54692/new/

https://reviews.llvm.org/D54692