[Lldb-commits] [PATCH] D54692: [Driver] Use libOption with tablegen.

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

In D54692#1308190 <https://reviews.llvm.org/D54692#1308190>, @labath wrote:

> > There’s actually been a slow push away from cl::opt. It’s less flexible
> >  and doesn’t support some things that the TableGen approach does.
> >  Recently there’s been a few efforts to port existing tools onto TableGen
> >  options from cl::opt.
> > 
> > I don’t think cl::opt is going away anytime soon so if it works I don’t
> >  have a strong opinion, but it’s kinda nice to standardize on “the one
> >  true method” if that’s the direction things are heading anyway
>
> Another reason for using libOption is that it is also usable as a parser for the lldb command line, whereas cl::opt is definitely not (it uses global variables). And there's value in consistency between the lldb driver and the built-in command line.


This is true too.  Although I believe libOption doesn't support subcommands, which would be required in order to use it for the interactive lldb command line, but again, there would be value in adding that to libOption outside of llvm (cl::opt supports it, so it's required in order to port some remaining llvm tools to libOption)


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54692/new/

https://reviews.llvm.org/D54692