[Lldb-commits] [PATCH] D54751: [LLDB] - Fix setting the breakpoints when -gsplit-dwarf and DWARF 5 were used for building the executable.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 26 07:21:53 PST 2018


clayborg added a comment.

Missed an inline comment on last comment



================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:311
+  dw_addr_t addr_base =
+          cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_addr_base, 0);
+  SetAddrBase(addr_base);
----------------
Use LLDB_INVALID_ADDRESS instead of zero as zero could be a valid base address.
```
dw_addr_t addr_base = cu_die.GetAttributeValueAsUnsigned(m_dwarf, this, DW_AT_addr_base, LLDB_INVALID_ADDRESS);
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54751/new/

https://reviews.llvm.org/D54751





More information about the lldb-commits mailing list