[Lldb-commits] [lldb] r346993 - Force SHELL to be cmd.exe on Windows for the test suite

Nathan Lanza via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 15 12:56:45 PST 2018

Author: lanza
Date: Thu Nov 15 12:56:44 2018
New Revision: 346993

URL: http://llvm.org/viewvc/llvm-project?rev=346993&view=rev
Force SHELL to be cmd.exe on Windows for the test suite

Windows make will search for other shells and choose those over cmd
if available (e.g. C:\cygdrive\bin\sh.exe). This shell has numerous
issues with path handling (/ vs \\ vs \ and C:). So default to using
cmd.exe which is known to work.

Reviewers: zturner, sas, xiaobai

Reviewed By: zturner

Differential Revision: https://reviews.llvm.org/D54510


Modified: lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules?rev=346993&r1=346992&r2=346993&view=diff
--- lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/make/Makefile.rules Thu Nov 15 12:56:44 2018
@@ -51,6 +51,17 @@ ifeq "$(OS)" ""
+# If OS is Windows, force SHELL to be cmd
+# Some versions of make on Windows will search for other shells such as
+# C:\cygwin\bin\sh.exe. This shell fails for numerous different reasons
+# so default to using cmd.exe.
+ifeq "$(OS)" "Windows_NT"
+	SHELL = $(WINDIR)\system32\cmd.exe
 # If TRIPLE is not defined try to set the ARCH, CC, CFLAGS, and more
 # from the triple alone

More information about the lldb-commits mailing list