[Lldb-commits] [PATCH] D54682: [Driver] Extract option parsing and option processing.
Zachary Turner via lldb-commits
lldb-commits at lists.llvm.org
Sun Nov 18 20:19:23 PST 2018
Lib option definitely does, as its entire purpose is to be powerful and
flexible enough to mimic arbitrary command line tools.
cl::opt is a little less powerful but it still preserves order among
multiple options with the same flag, just not multiple options with
I don’t have a strong opinion that this particular change should be gated
on that, it’s just nice when we can reuse llvm logic. Sometimes it fixes
latent bugs, sometimes it enables new functionality that wasn’t possible
before, etc. up to you if you wanna give it a shot
On Sun, Nov 18, 2018 at 7:39 PM Jonas Devlieghere via Phabricator <
reviews at reviews.llvm.org> wrote:
> JDevlieghere added a comment.
> In https://reviews.llvm.org/D54682#1302436, @zturner wrote:
> > I’ve often thought we should convert LLDB’s command line parsing code
> > to use either cl::opt or lib/Option. This would also solve the problem
> > describe here at the same time.
> > Do you think it’s worth trying to do this?
> I believe both would have the issue that options are not processed in the
> order specified. I guess it depends on whether people care about this?
> Happy to give that a shot if the consensus is "nobody cares" :-)
> rLLDB LLDB
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits