[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Fri Nov 16 20:01:31 PST 2018


Well msvc implies system-windows, but i can have both
On Fri, Nov 16, 2018 at 7:37 PM Stella Stamenova via Phabricator <
reviews at reviews.llvm.org> wrote:

> stella.stamenova accepted this revision.
> stella.stamenova added a comment.
> This revision is now accepted and ready to land.
>
> Feel free to check this in. At this point this will only improve the
> results on Windows and it works correctly on Linux.
>
>
>
> ================
> Comment at: lldb/lit/SymbolFile/PDB/class-layout.test:1
> -REQUIRES: system-windows
> -RUN: clang-cl -m32 /Z7 /c /GS- %S/Inputs/ClassLayoutTest.cpp /o
> %T/ClassLayoutTest.cpp.obj
> -RUN: link %T/ClassLayoutTest.cpp.obj /DEBUG /nodefaultlib /ENTRY:main
> /OUT:%T/ClassLayoutTest.cpp.exe
> +REQUIRES: msvc
> +RUN: %clang_cl -m32 /Z7 /c /GS- %S/Inputs/ClassLayoutTest.cpp /o
> %T/ClassLayoutTest.cpp.obj
> ----------------
> Why only msvc and not system-windows like the rest of the tests?
>
>
> https://reviews.llvm.org/D54567
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181116/ba01285b/attachment-0001.html>


More information about the lldb-commits mailing list