[Lldb-commits] [PATCH] D54616: [Reproducers] Improve reproducer API and add unit tests.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere created this revision.
JDevlieghere added reviewers: davide, shafik, friss, jingham.
JDevlieghere added a project: LLDB.
Herald added subscribers: abidh, mgorny.

When I landed the initial reproducer framework I knew there were some things that needed improvement. Rather than bundling it with a patch that adds more functionality I split it off into this patch. I also think the API is stable enough to add unit testing, which is included in this patch as well.

Other improvements include:

- Refactor how we initialize the loader and generator.
- Improve naming consistency: capture and replay seems the least ambiguous.
- Index providers by name and make sure there's only one of each.
- Add convenience methods for creating and accessing providers.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D54616

Files:
  include/lldb/Core/Debugger.h
  include/lldb/Utility/Reproducer.h
  source/API/SBDebugger.cpp
  source/Commands/CommandObjectReproducer.cpp
  source/Core/Debugger.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Utility/Reproducer.cpp
  unittests/Utility/CMakeLists.txt
  unittests/Utility/ReproducerTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54616.174330.patch
Type: text/x-patch
Size: 22093 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181116/684efaf8/attachment-0001.bin>