[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

[Zachary Turner via Phabricator via lldb-commits]

zturner added a comment.

In https://reviews.llvm.org/D54567#1300029, @stella.stamenova wrote:

> In https://reviews.llvm.org/D54567#1299999, @zturner wrote:
>
> > In https://reviews.llvm.org/D54567#1299993, @stella.stamenova wrote:
> >
> > > In https://reviews.llvm.org/D54567#1299992, @aprantl wrote:
> > >
> > > > In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote:
> > > >
> > > > > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from the cmake files along with this change, otherwise, people will still expect them to work.
> > > >
> > > >
> > > > That would not be a good idea. There are several bots that are using these flags.
> > >
> > >
> > > The change that Zachary is making is removing their usage, so after his change they would not do anything. If he ends up committing this change, these two properties (along with LLDB_DEFAULT_TEST_C_COMPILER and LLDB_TEST_USE_CUSTOM_C_COMPILER, etc.) should also go.
> >
> >
> > The flags are still needed for (and used by) the dotest suite, I didn't change that part.  Normally you run that suite by doing `ninja check-lldb`, in which case it never goes through these lit files to begin with.  But they will also run as part of `ninja check-lldb-lit`, but that lit configuration file totally overrides everything in the parent one, so nothing in this patch should have any effect on that.
>
>
> I think this is actually confusing - there are two ways to specify compilers for the lldb test suite at cmake time:
>
> 1. Via LLDB_TEST_USE_CUSTOM_C_COMPILER and friends
> 2. Via LLDB_TEST_USER_ARGS
>
>   As far as I can tell, the ubuntu 14 bot that @aprantl pointed to uses the LLDB_TEST_USER_ARGS path. I *think* the green dragon bots also use the LLDB_TEST_USER_ARGS and AFAIK it's the only way gcc is ever specified for the tests. If the LLDB_TEST_USE_CUSTOM_C_COMPILER and friends are not used for the lit tests, I don't think we need them for the suite tests.


The ubuntu bot doesn't use the cmake configuration at all.  It runs the test in 6 different configurations, but CMake gives you exactly 1 configuration, so it can't do things that way.  AFAICT the Ubuntu bot adrian linked has 6 different shell scripts that manually construct the proper `dotest` command lines.


https://reviews.llvm.org/D54567