[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Nov 15 09:13:54 PST 2018

aprantl added a comment.

In https://reviews.llvm.org/D54567#1299997, @zturner wrote:

> It's possible I didn't make this part clear enough.  I didn't mean that nobody is using `LLDB_TEST_C_COMPILER`, I meant that nobody is using it **in order to compile inferiors with gcc**.  There is also a dichotomy between what happens for the dotest suite and the lit suite.  For the dotest suite, `LLDB_TEST_C(XX)_COMPILER` are still respected, this patch hasn't changed that.  It has only changed the behavior of running tests in `lldb/lit/{Breakpoint/Expr/Modules/Quit/Settings/SymbolFile/tools}`.  Even for those tests, it is still possible to use a not-just-built clang, just that instead of specifying `LLDB_TEST_C(XX)_COMPILER`, you now specify `LLDB_LIT_TOOLS_DIR`.

Thanks, that makes more sense to me! (I'm still not sure that it is correct though: cf. http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/31242)

In https://reviews.llvm.org/D54567#1299999, @zturner wrote:

> The flags are still needed for (and used by) the dotest suite, I didn't change that part.  Normally you run that suite by doing `ninja check-lldb`, in which case it never goes through these lit files to begin with.  But they will also run as part of `ninja check-lldb-lit`, but that lit configuration file totally overrides everything in the parent one, so nothing in this patch should have any effect on that.

Do we document the fact that the two testsuites behave differently in this respect? I'm worried that developers that aren't aware of that difference will test new functionality only with a LIT test out of convenience (because they are more familiar with this style from LLVM) and that that will erode our test coverage on other or older compilers over time.


More information about the lldb-commits mailing list