[Lldb-commits] [PATCH] D54221: Add setting to require hardware breakpoints.
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 14 12:31:41 PST 2018
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
The lldb API's parameters are ordered input first than output. Pretty much all the API's that take a Status as a parameter take it as the last parameter. So it looks weird to have the Status &error first in the QueueThreadPlan... API's. This pattern gets annoying when you have default parameters, so it's okay to put the out parameters before the default parameters (though default parameters are also not so great, so removing them is also okay...)
Other than that this looked fine.
More information about the lldb-commits