[Lldb-commits] [PATCH] D54009: Refactor LLDB lit configuration files
Stella Stamenova via lldb-commits
lldb-commits at lists.llvm.org
Tue Nov 13 15:16:43 PST 2018
I took a brief look and I have a question about the usage of clang (rather than clang-cl).
In general I would agree that we have an exact path of clang (or gcc) that we are trying to use and they’re specified by using %cc and %cxx in the test files, but there are a number of test files that simply use clang e.g.:
SymbolFile\DWARF\find-variable-dwo.cpp:3:// RUN: clang %s -g -gsplit-dwarf -c -emit-llvm -o - --target=x86_64-pc-linux -DONE
In this case, are we not going to pick up whatever clang happens to be in the path instead of one that was explicitly specified? Is this intentional?
From: Zachary Turner <zturner at google.com>
Sent: Tuesday, November 13, 2018 2:46 PM
To: reviews+D54009+public+0e164460da8f1d7f at reviews.llvm.org
Cc: Stella Stamenova <stilis at microsoft.com>; pavel at labath.sk; chris.bieneman at me.com; dccitaliano at gmail.com; aleksandr.urakov at jetbrains.com; jdevlieghere at apple.com; abidh.haq at gmail.com; teemperor at gmail.com; ki.stfu at gmail.com; mgorny at gentoo.org; dan at su-root.co.uk; jfbastien at apple.com; lldb-commits at lists.llvm.org; llvm at inglorion.net
Subject: Re: [PATCH] D54009: Refactor LLDB lit configuration files
I think it must be related to setting up the environment in which to run clang. In all other projects we call llvm_config.use_clang() which is in llvm/utils/lit/lit/llvm/config.py, but because here we have an exact path of a clang we are trying to use, we skip this function in LLDB's lit configuration files. But there is also a lot of other logic in that function, so perhaps it's some of that logic that's necessary.
On Mon, Nov 12, 2018 at 9:02 AM Aleksandr Urakov via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
aleksandr.urakov added a comment.
But all compiles without errors if I run this manually:
clang-cl -m32 /Z7 /c /GS- C:\Work\llvm\tools\lldb\lit\SymbolFile\PDB/Inputs/SimpleTypesTest.cpp /o C:\Work\llvm\build_x86\tools\lldb\lit\SymbolFile\PDB\Output/SimpleTypesTest.cpp.enums.obj
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lldb-commits