[Lldb-commits] [PATCH] D54452: [NativePDB] Add support for handling S_CONSTANT records

Shafik Yaghmour via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Nov 13 09:48:28 PST 2018

shafik added inline comments.

Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:329
+std::pair<size_t, bool> GetIntegralTypeInfo(TypeIndex ti, TpiStream &tpi) {
+  if (ti.isSimple()) {
lemo wrote:
> Just a suggestion: I'm not a big fan of returning std::pair<>. I'd use a simple struct instead.
I have to concur on this, although the use of `std::tie` helps alleviate the pain i.e. no `second` and `first` it does feel more verbose on the calling side to declare two variables and then do the tie and it relies on the calling to choose meaningful names which can't be relied on if the use spreads and people are not as careful.


More information about the lldb-commits mailing list