[Lldb-commits] [PATCH] D54454: Be more permissive in what we consider a variable name.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 12 18:34:34 PST 2018

clayborg added a comment.

In https://reviews.llvm.org/D54454#1296392, @zturner wrote:

> BTW, I will have to see if it's possible to write a test for this.  Even when I compiled and built a program with DWARF on Linux, the `target variable Pi<double>` example didn't "just work" for me, because `FindGlobalVariables` wasn't returning the variable.  So I think this part actually needs to be fixed in the DWARF plugin, which I'm not equipped to fix.  I can try something that is not a variable template, such as the `Foo<int>::StaticMember` example, but if that also doesn't work, then there might not be a good way to write a general purpose test for this until this is fixed in the DWARF plugin.
> I can definitely add a test in the native pdb plugin though, and technically that runs everywhere (although it would only test `target variable` and not `frame variable`, maybe that's ok though?).

It is the template stuff that throws things off. Can't remember if there is an accelerator table entry for those. Global variables in general work. It would be good to figure out what this doesn't work for DWARF. I will take a look.


More information about the lldb-commits mailing list