[Lldb-commits] [PATCH] D54454: Be more permissive in what we consider a variable name.

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

You were probably speaking loosely, but to be clear, the code you are changing doesn't get used for expressions - i.e. the expression command - unless I'm missing something.

This little mini-parser is for doing things like:

(lldb) frame variable foo.bar

We don't use clang or the expression parser to comprehend foo.bar, we use GetValuesForVariableExpressionPath instead.  But 'frame variable' 'target variable' etc. which use this are fairly limited in what they need to support.  They just needs to handle variable references - either local variables or static variables, and references to children of those variables.  No calls, no casts, no types, etc.

So I don't see that the ability to handle template definition markers like <int> is important.  I don't see how that would show up in a variable name or the name of one of its children.


https://reviews.llvm.org/D54454