[Lldb-commits] [PATCH] D54452: [NativePDB] Add support for handling S_CONSTANT records

Leonard Mosescu via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Nov 12 15:37:39 PST 2018

lemo accepted this revision.
lemo added inline comments.
This revision is now accepted and ready to land.

Comment at: lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp:329
+std::pair<size_t, bool> GetIntegralTypeInfo(TypeIndex ti, TpiStream &tpi) {
+  if (ti.isSimple()) {
Just a suggestion: I'm not a big fan of returning std::pair<>. I'd use a simple struct instead.


More information about the lldb-commits mailing list