[Lldb-commits] [lldb] r346430 - Fix bug in PE/COFF plugin and ValueObjectVariable.

[Davide Italiano via lldb-commits]

Cool. I see several tests failing (so there might be multiple issues).

Failing Tests (9):
    LLDB :: tools/lldb-mi/symbol/symbol-list-lines.test
    lldb-Suite ::
functionalities/breakpoint/scripted_bkpt/TestScriptedResolver.py
    lldb-Suite :: functionalities/type_completion/TestTypeCompletion.py
    lldb-Suite :: lang/objc/hidden-ivars/TestHiddenIvars.py
    lldb-Suite :: lang/objc/ivar-IMP/TestObjCiVarIMP.py
    lldb-Suite :: lang/objc/objc-ivar-stripped/TestObjCIvarStripped.py
    lldb-Suite :: macosx/add-dsym/TestAddDsymMidExecutionCommand.py
    lldb-Suite ::
macosx/find-dsym/bundle-with-dot-in-filename/TestBundleWithDotInFilename.py
    lldb-Suite :: macosx/find-dsym/deep-bundle/TestDeepBundle.py

  Expected Passes    : 1325
  Unsupported Tests  : 43
  Unexpected Failures: 9


I guess a bisect and revert is in order here.

--
Davide
On Thu, Nov 8, 2018 at 1:27 PM Zachary Turner <zturner at google.com> wrote:
>
> Go ahead and revert to green until i get back
> On Thu, Nov 8, 2018 at 1:17 PM Zachary Turner <zturner at google.com> wrote:
>>
>> +greg.
>>
>> Greg, is the test wrong here or the patch?  If it’s the test let’s just fix the test, otherwise we can revert the patch until we figure it out.
>>
>> It seems related to my change to use the layout type instead of the forward type.
>>
>> On Thu, Nov 8, 2018 at 1:03 PM Davide Italiano <dccitaliano at gmail.com> wrote:
>>>
>>> On Thu, Nov 8, 2018 at 12:59 PM Zachary Turner <zturner at google.com> wrote:
>>> >
>>> > I’m ooo for at least 2 hours. Is it a test failure or a compilation failure?
>>>
>>>
>>> FAIL: test_with_run_command_gmodules (TestTypeCompletion.TypeCompletionTestCase)
>>>
>>>    Check that types only get completed when necessary.
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>>   File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/lldbtest.py",
>>> line 1744, in test_method
>>>     return attrvalue(self)
>>>   File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/decorators.py",
>>> line 113, in wrapper
>>>     func(*args, **kwargs)
>>>   File "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/functionalities/type_completion/TestTypeCompletion.py",
>>> line 55, in test_with_run_command 'vector<T> complete but it should
>>> not be')
>>> AssertionError: True is not False : vector<T> complete but it should not be
>>>
>>>
>>> Do you want me to revert this in the meanwhile?
>>>
>>> --Davide