[Lldb-commits] [lldb] r346430 - Fix bug in PE/COFF plugin and ValueObjectVariable.

[Zachary Turner via lldb-commits]

+greg.

Greg, is the test wrong here or the patch?  If it’s the test let’s just fix
the test, otherwise we can revert the patch until we figure it out.

It seems related to my change to use the layout type instead of the forward
type.

On Thu, Nov 8, 2018 at 1:03 PM Davide Italiano <dccitaliano at gmail.com>
wrote:

> On Thu, Nov 8, 2018 at 12:59 PM Zachary Turner <zturner at google.com> wrote:
> >
> > I’m ooo for at least 2 hours. Is it a test failure or a compilation
> failure?
>
>
> FAIL: test_with_run_command_gmodules
> (TestTypeCompletion.TypeCompletionTestCase)
>
>    Check that types only get completed when necessary.
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File
> "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/lldbtest.py",
> line 1744, in test_method
>     return attrvalue(self)
>   File
> "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/decorators.py",
> line 113, in wrapper
>     func(*args, **kwargs)
>   File
> "/Users/davide/work/llvm-project-20170507/lldb/packages/Python/lldbsuite/test/functionalities/type_completion/TestTypeCompletion.py",
> line 55, in test_with_run_command 'vector<T> complete but it should
> not be')
> AssertionError: True is not False : vector<T> complete but it should not be
>
>
> Do you want me to revert this in the meanwhile?
>
> --Davide
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181108/191aa4c2/attachment.html>