[Lldb-commits] [PATCH] D54241: Fix bug in printing ValueObjects and in PE/COFF Plugin
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Nov 7 17:14:11 PST 2018
zturner updated this revision to Diff 173095.
zturner added a comment.
I added a test specifically for the bss bug. Even though one of my existing broken tests became fixed, someone could come down the line and adjust the test and set one of the variables to 1 which would cause the data to go into a regular section. To make sure this doesn't happen, I made a specific test just for this, and used `llvm-readobj` to also check that that the size of the section is in fact 0. So this test will always fail if the section stops being a compressed bss section for whatever reason.
https://reviews.llvm.org/D54241
Files:
lldb/lit/SymbolFile/NativePDB/Inputs/globals-bss.lldbinit
lldb/lit/SymbolFile/NativePDB/ast-reconstruction.cpp
lldb/lit/SymbolFile/NativePDB/globals-bss.cpp
lldb/source/Core/ValueObjectVariable.cpp
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54241.173095.patch
Type: text/x-patch
Size: 6123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181108/6e313474/attachment.bin>
More information about the lldb-commits
mailing list