[Lldb-commits] [PATCH] D54003: Refactor ClangASTContext::AddEnumerationValueToEnumerationType() to remove redundant parameter which can be calculated from other parameter

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Wed Nov 7 14:28:25 PST 2018


I meant the folder. It’s the first result in your search results. Just
curious, why does your build successfully complete without fixing that
instance?
On Wed, Nov 7, 2018 at 2:20 PM Shafik Yaghmour via Phabricator <
reviews at reviews.llvm.org> wrote:

> shafik added a comment.
>
> @zturner I don't see `AddEnumerationValueToEnumerationType` being called
> in `SymbolFile/NativePDB.cpp`
> https://github.com/llvm-mirror/lldb/search?q=AddEnumerationValueToEnumerationType&unscoped_q=AddEnumerationValueToEnumerationType
>
>
> https://reviews.llvm.org/D54003
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181107/48df6066/attachment.html>


More information about the lldb-commits mailing list