[Lldb-commits] [PATCH] D54053: [NativePDB] Add the ability to create clang record decls from mangled names.

[Aleksandr Urakov via Phabricator via lldb-commits]

aleksandr.urakov accepted this revision.
aleksandr.urakov added a comment.

In https://reviews.llvm.org/D54053#1286653, @zturner wrote:

> Bleh, I think I found a problem with this approach.  Since we assume everything is a namespace, it can lead to ambiguities.  I think we need to actually consult the debug info while parsing components of the mangled name.


Yes, it is what actually we have done in `PDBASTParser::GetDeclContextContainingSymbol`. Also I think that it is worth to remember if we already have created the class / function parent before, and do not create namespaces in this case. For example: `N0::N1::CClass::PrivateFunc::__l2::InnerFuncStruct`. We have here the `PrivateFunc` function and the `InnerFuncStruct` structure inside it. So we do not need to create the `__l2` namespace inside the `PrivateFunc` function (moreover, it is not possible to create a namespace inside a class / function).

There is a similar problem with global and static variables and functions. Are the mangled names presented for them? Can we solve it in the same way?

Anyway, I think that this patch is a great start!


https://reviews.llvm.org/D54053