[Lldb-commits] [lldb] r346186 - [TestVLA] Fix a python decorator.

[Adrian Prantl via lldb-commits]

Thanks!!

You could also change the import line to

> from lldbsuite.test.decorators import *

and leave the decorator as-is.

-- adrian


> On Nov 5, 2018, at 4:21 PM, Davide Italiano <dccitaliano at gmail.com> wrote:
> 
> @Adrian, this should be fairly straightforward, but a post-commit
> review is always appreciated.
> On Mon, Nov 5, 2018 at 4:20 PM Davide Italiano via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>> 
>> Author: davide
>> Date: Mon Nov  5 16:18:17 2018
>> New Revision: 346186
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=346186&view=rev
>> Log:
>> [TestVLA] Fix a python decorator.
>> 
>> Modified:
>>    lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py
>> 
>> Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py
>> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py?rev=346186&r1=346185&r2=346186&view=diff
>> ==============================================================================
>> --- lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py (original)
>> +++ lldb/trunk/packages/Python/lldbsuite/test/lang/c/vla/TestVLA.py Mon Nov  5 16:18:17 2018
>> @@ -1,5 +1,6 @@
>> import lldb
>> from lldbsuite.test.lldbtest import *
>> +from lldbsuite.test import decorators
>> import lldbsuite.test.lldbutil as lldbutil
>> 
>> 
>> @@ -7,7 +8,7 @@ class TestVLA(TestBase):
>> 
>>     mydir = TestBase.compute_mydir(__file__)
>> 
>> -    @skipIf(compiler="clang", compiler_version=['<', '8.0'])
>> +    @decorators.skipIf(compiler="clang", compiler_version=['<', '8.0'])
>>     def test_vla(self):
>>         self.build()
>>         _, process, _, _ = lldbutil.run_to_source_breakpoint(
>> 
>> 
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits