[Lldb-commits] [PATCH] D54059: Remove Java debugger plugin

[Tamas Berghammer via Phabricator via lldb-commits]

tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.

LGTM. Thank you for removing it.



================
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:84
   Token = 19,
-  JavascriptData = 20,
   SystemMemoryInfo = 21,
----------------
This is JavaScript and not Java. Also I think this is a constant what is coming from the minidump spec so I would leave it even after we removed Java support from LLDB.


================
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:155
   EDSP = (1 << 7),
-  Java = (1 << 8),
   IWMMXT = (1 << 9),
----------------
I think this is a constant what is coming from the minidump spec so I would leave it even after we removed Java support from LLDB


https://reviews.llvm.org/D54059