[Lldb-commits] [PATCH] D53435: [x86] Fix issues with a realigned stack in MSVC compiled applications

[Aleksandr Urakov via Phabricator via lldb-commits]

aleksandr.urakov marked 2 inline comments as done.
aleksandr.urakov added a comment.

Thank you! I'll update the patch.



================
Comment at: source/Plugins/Process/Utility/RegisterContextLLDB.h:195
 
   // Get the CFA register for a given frame.
+  bool ReadFrameAddress(lldb::RegisterKind register_kind,
----------------
jasonmolenda wrote:
> Comment update, e.g. Get the Frame Address register for a given frame.
Yes, thanks for pointing to that!


================
Comment at: source/Symbol/UnwindPlan.cpp:202
+  m_afa_value.Dump(s, unwind_plan, thread);
+
   s.Printf(" => ");
----------------
jasonmolenda wrote:
> What do you think about only printing the AFA= entry if it is != LLDB_INVALID_ADDRESS?
Yes, sure!


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53435