[Lldb-commits] [PATCH] D53788: [FileSystem] Remove GetByteSize() from FileSpec

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

Are we refactoring in the right place? Why not just refactor `FileSpec::GetByteSize()` why is `FileSpec` the wrong place?



================
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:718
+                  (FileSystem::Instance().GetByteSize(file) - file_offset) /
+                      1024);
 
----------------
`1024u` just for consistency, I don't expect this is practically a problem.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53788