[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

[Alexander Polyakov via Phabricator via lldb-commits]

apolyakov added a comment.

I ran the test and got a fail:

  build/bin/llvm-lit -avv llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test 
  -- Testing: 1 tests, 1 threads --
  FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of 1)
  ******************** TEST 'lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test' FAILED ********************
  Script:
  --
  : 'RUN: at line 4';   /home/alexander/workspace/gsoc/build/./bin/clang -o b.exe /home/alexander/workspace/gsoc/llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/inputs/break-insert-pending.c -g
  : 'RUN: at line 5';   /home/alexander/workspace/gsoc/build/bin/lldb-mi --synchronous < /home/alexander/workspace/gsoc/llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test | /home/alexander/workspace/gsoc/build/bin/FileCheck /home/alexander/workspace/gsoc/llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test
  --
  Exit Code: 1
  
  Command Output (stderr):
  --
  /home/alexander/workspace/gsoc/llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:25:10: error: CHECK: expected string not found in input
  # CHECK: =breakpoint-modified,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",addr="{{0x[0-9a-f]*[^f][0-9a-f]*}}",func="??",file="??",fullname="??/??",line="0",pending=["printf"],times="{{0|1}}",original-location="printf"}
           ^
  <stdin>:40:1: note: scanning from here
  =thread-group-started,id="i1",pid="11020"
  ^
  
  --
  
  ********************
  Testing Time: 0.72s
  ********************
  Failing Tests (1):
      lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test
  
    Unexpected Failures: 1



================
Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4
+#
+# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g
+# RUN: %lldbmi < %s | FileCheck %s
----------------
malaperle wrote:
> apolyakov wrote:
> > As far as your first command is `file-exec-and-symbols`, the best way is to use a generic executable's name. Here it should be:
> > ```
> > # RUN: %cc -o %t %p/inputs/break-insert-pending.c -g
> > # RUN: %lldbmi %t < %s | FileCheck %s
> > ```
> How can I use %t for the second file-exec-and-symbols? It doesn't seem to work
Should you use `file-exec-and-symbols` two times? AFAIK, after exiting a program, your target remains the same, so you don't need to load it again.


https://reviews.llvm.org/D52953