[Lldb-commits] [PATCH] D53597: Don't type-erase the SymbolContextItem enum

[Jim Ingham via lldb-commits]

So far as I can tell, this patch will make lookup of exact types faster for PDB, but because of the way DWARF debug_names tables are constructed, I don't think there's any way we can do the same thing for DWARF.

But unless I'm misunderstanding the patch, this doesn't change correctness of the lookup (except for fixing "type lookup 'struct Foo'").  Did I miss something?

Jim


> On Oct 25, 2018, at 10:42 AM, Zachary Turner via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> zturner added a comment.
> 
> In https://reviews.llvm.org/D53597#1276086, @clayborg wrote:
> 
>> As long as Swig is happy and the ABI doesn't change I am ok with this. Will we see the variables better when debugging? Or is this solely so the SymbolContextItem type doesn't disappear from the debug info?
> 
> 
> We will see variables better when debugging too.
> 
> 
> https://reviews.llvm.org/D53597
> 
> 
>