[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

[Aleksandr Urakov via Phabricator via lldb-commits]

aleksandr.urakov updated this revision to Diff 170889.
aleksandr.urakov added a comment.

I've implemented things as Greg have said, except for a few moments:

- haven't added `AddSymbols` to `SymbolVendor` because it is not used anywhere, and we can just use `SymbolFile::AddSymbols` directly inside of `SymbolVendor`;
- have made `AddSymbols`' parameter as a reference instead of a pointer, because there is no reason to send null to this function;
- have cached symtab in `SymbolVendor` to not pass it every time through the `SymbolFile::AddSymbols`.

But if you don't agree with some of these I'm ready to discuss.


https://reviews.llvm.org/D53368

Files:
  include/lldb/Symbol/SymbolFile.h
  include/lldb/Symbol/SymbolVendor.h
  include/lldb/lldb-forward.h
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
  source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
  source/Symbol/SymbolVendor.cpp
  unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53368.170889.patch
Type: text/x-patch
Size: 7925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181024/6a43fc78/attachment.bin>