[Lldb-commits] [PATCH] D53094: [pecoff] Implement ObjectFilePECOFF::GetDependedModules()

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 23 16:38:43 PDT 2018


zturner added a comment.

In https://reviews.llvm.org/D53094#1273556, @asmith wrote:

> I think this addresses all the previous comments.


Still didn't get a clear answer if the mutex being used needs to be recursive.  If it doesn't, perhaps `std::mutex` can be used instead of `std::recursive_mutex`?  Not everyone agrees with me, but I often prefer to be too strict rather than too relaxed.


https://reviews.llvm.org/D53094





More information about the lldb-commits mailing list