[Lldb-commits] [PATCH] D53590: Refactor SetBaseClassesForType and DeleteBaseClasses to be more C++'y

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added a comment.

+1 for modernizing code!



================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2262
+          // assertion in the call to clang_type.TransferBaseClasses()
+          for (auto &base_class : bases) {
             clang::TypeSourceInfo *type_source_info =
----------------
`const auto &`


================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:3274
+          if (!result)
+            break;
+
----------------
Is this correct? the if/else below does not seem dependent on this result?


https://reviews.llvm.org/D53590