[Lldb-commits] [PATCH] D53532: [FileSpec] Add VFS support

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 23 11:05:13 PDT 2018


labath added a comment.

Back when the FileSystem class was introduced, the idea was that *it* would eventually become the gateway to the real filesystem, and FileSpec would just deal with abstract path manipulation.

I still think that is a good idea, particularly in light of this patch. So I would propose to integrate this VFS functionality into that class, and then remove any operations that touch real files from the file spec class.

(Also, given that now about 50% of filesystem operations go through FileSpec and the other half through FileSystem (or other methods), any attempts to use FileSpec to control how filenames are interpreted will not be complete).


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53532





More information about the lldb-commits mailing list