[Lldb-commits] [PATCH] D53511: [NativePDB] Support type lookup by name

[Leonard Mosescu via Phabricator via lldb-commits]

lemo added a comment.

Nice :)



================
Comment at: lldb/lit/SymbolFile/NativePDB/tag-types.cpp:87
+// Test single inheritance.
+class Derived : public Class {
+public:
----------------
- at least one virtual function + override?
- at least one method returning void?


================
Comment at: lldb/lit/SymbolFile/NativePDB/tag-types.cpp:94
+  // infinite cycle.
+  Derived &Reference;
+
----------------
pointer to itself too?


================
Comment at: lldb/lit/SymbolFile/NativePDB/tag-types.cpp:110
+
+// Test multiple inheritance, as well as protected and private inheritance.
+class Derived2 : protected Class, private Struct {
----------------
just an idea - add a virtual inheritance variation?


================
Comment at: lldb/lit/SymbolFile/NativePDB/tag-types.cpp:131
+
+int main(int argc, char **argv) {
+  Struct S;
----------------
a few suggestions for additional things to cover:
- local classes
- lambdas
- instantiating class and function templates
   - explicit specializations
   - for classes, partial specializations
- namespaces
- anonymous namespace


https://reviews.llvm.org/D53511