[Lldb-commits] [PATCH] D51578: DWARFConcatenatingDataExtractor for D32167

[Jan Kratochvil via Phabricator via lldb-commits]

jankratochvil updated this revision to Diff 170342.
jankratochvil added a comment.
Herald added a subscriber: arphaman.

Patch `concat` = original posting with `DWARFConcatenatingDataExtractor` used only for `.debug_info`(+`.debug_types`) section. download <https://people.redhat.com/jkratoch/concat.patch>
Patch `concat2` = used `DWARFDataExtractor` with integrated concatenation for all DWARF sections. download <https://people.redhat.com/jkratoch/concat2.patch>

  master  real=0.996s user=14.744s sys=1.050s
  concat  real=0.994s user=15.524s sys=1.117s
  concat2 real=1.001s user=15.580s sys=1.334s

`concat` vs. `concat2` benchmark difference was mostly a measurement error. It is now 5% slowdown compared to trunk - even for former `concat` which I do not understand now, I will investigate it more as my original measured slowdown was just 1% before.
`concat2` sometimes needs to cast `DWARFDataExtractor` to `DataExtractor` by `.AsDataExtractor()` as some functions expected a contiguous block of memory. That is a method applicable only for non-`.debug_info` sections (it would assert on `.debug_info`). It needs to be called as `DWARFDataExtractor` can no longer inherit `DataExtractor`. I did not use `operator DataExtractor &` as it could accidentally by applied to `.debug_info` which may be difficult to catch when not tested with `-fdebug-types-section`.
`DataExtractorConcat` is a separate class but it is never used separately without `DWARFDataExtractor` inheriting it.
Greg, do you mean it somehow way or do I miss something? Personally I may like a bit more `concat` but then the patch size is almost the same for both.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D51578

Files:
  source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp
  source/Plugins/SymbolFile/DWARF/DWARFASTParserGo.cpp
  source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
  source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.h
  source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h
  source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.cpp
  source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
  source/Plugins/SymbolFile/DWARF/DWARFTypeUnit.cpp
  source/Plugins/SymbolFile/DWARF/DWARFTypeUnit.h
  source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
  source/Plugins/SymbolFile/DWARF/DWARFUnit.h
  source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
  source/Plugins/SymbolFile/DWARF/HashedNameToDIE.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwo.cpp
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDwp.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51578.170342.patch
Type: text/x-patch
Size: 39516 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181021/8e9715ed/attachment-0001.bin>