[Lldb-commits] [PATCH] D53092: [lldb] Add support in Status::AsCString to retrieve win32 system error strings

[Aaron Smith via Phabricator via lldb-commits]

asmith added inline comments.


================
Comment at: unittests/Utility/StatusTest.cpp:68-74
+  EXPECT_STREQ("Access is denied. ", s.AsCString());
+
+  s.SetError(ERROR_IPSEC_IKE_TIMED_OUT, ErrorType::eErrorTypeWin32);
+  EXPECT_STREQ("Negotiation timed out ", s.AsCString());
+
+  s.SetError(16000, ErrorType::eErrorTypeWin32);
+  EXPECT_STREQ("unknown error", s.AsCString());
----------------
aleksandr.urakov wrote:
> I'm not sure, can we rely on the fact that messages are the same in different versions of Windows?
I don't think the errors are different but I don't have old versions of Windows setup to test. Everyone should be on Win10 right :-) I'll keep an eye on the buildbots after I commit.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53092