[Lldb-commits] [PATCH] D52461: [PDB] Introduce `PDBNameParser`

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Oct 16 07:49:58 PDT 2018


labath added a comment.

In https://reviews.llvm.org/D52461#1266302, @aleksandr.urakov wrote:

>   `operator<<A>'::`2'::B::operator>
>


The reason we had to use clang lexer for parsing itanium names is because parsing itanium demangled names is tricky precisely for cases like these. If the MSVC demangler makes these cases trivial by enclosing them in quotes, maybe a separate (simpler) parser is not such a bad idea.

However, I still think this should be done within the scope of `CPlusPlusLanguage::MethodName` otherwise, you'll have to special case MSVC for all existing uses of this class.


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D52461





More information about the lldb-commits mailing list