[Lldb-commits] [PATCH] D53208: [lldbsuite] Fix the mac version decorator to work on non-mac platforms

[Shafik Yaghmour via Phabricator via lldb-commits]

shafik added inline comments.


================
Comment at: packages/Python/lldbsuite/test/decorators.py:194
             py_version[0], py_version[1], sys.version_info)
-        skip_for_macos_version = (macos_version is None) or (
+        skip_for_macos_version = (macos_version is None) or (platform.mac_ver()[0] == "") or (
             _check_expected_version(
----------------
If I am reading the following code correctly this will default to skipping when `platform.mac_ver()[0]  == ""` shouldn't it be the other way around? 


Repository:
  rLLDB LLDB

https://reviews.llvm.org/D53208