[Lldb-commits] [PATCH] D49271: Adding libc++ formattors for std::optional

Stella Stamenova via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Oct 12 12:56:59 PDT 2018


stella.stamenova added a comment.

In https://reviews.llvm.org/D49271#1263842, @shafik wrote:

> @stella.stamenova Thank you for catching this. I fixed the test names, I am looking into the best way to fix the skipif now.


@shafik I send a change for review this morning that I think should do the trick: https://reviews.llvm.org/D53208. The other option is to change the skipIf to include the os like some of the other ones.


https://reviews.llvm.org/D49271





More information about the lldb-commits mailing list