[Lldb-commits] [PATCH] D53166: [lldbsuite] Fix the filecheck functionality to work with Python 3
Stella Stamenova via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Oct 12 10:45:38 PDT 2018
stella.stamenova updated this revision to Diff 169459.
stella.stamenova edited the summary of this revision.
stella.stamenova added a comment.
Force the comparison in filecheck to use text rather than bytes
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53166
Files:
packages/Python/lldbsuite/test/lldbtest.py
Index: packages/Python/lldbsuite/test/lldbtest.py
===================================================================
--- packages/Python/lldbsuite/test/lldbtest.py
+++ packages/Python/lldbsuite/test/lldbtest.py
@@ -2240,7 +2240,7 @@
filecheck_args = [filecheck_bin, check_file_abs]
if filecheck_options:
filecheck_args.append(filecheck_options)
- subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE)
+ subproc = Popen(filecheck_args, stdin=PIPE, stdout=PIPE, stderr=PIPE, universal_newlines = True)
cmd_stdout, cmd_stderr = subproc.communicate(input=output)
cmd_status = subproc.returncode
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53166.169459.patch
Type: text/x-patch
Size: 673 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20181012/bcc26778/attachment.bin>
More information about the lldb-commits
mailing list